SaveBoundaryValues with restarted run

Clearly defined bug reports and their fixes
Post Reply
joeatodd
Posts: 36
Joined: 02 Feb 2012, 18:49
Antispam: Yes

SaveBoundaryValues with restarted run

Post by joeatodd »

Hi,

I believe there's a problem with the SaveBoundaryValues routine when restarting from a run in which SaveBoundaryValues was already used, and all the requested Parameters already exist as variables. In this situation, values are never updated and so any VTU, SaveLine or result file output shows the initial values.

I think this is due to the use of the logical ParamsExist, which is only ever set to .TRUE. once a variable has been created. Thus, if the routine finds that all the variables already exist, ParamsExist never becomes .TRUE. and so the following is executed every timestep:

Code: Select all

  IF( .NOT. ParamsExist ) THEN
     CALL WARN( 'SaveBoundaryValues', 'Parameters are not to be found. Nothing will be written')
     RETURN
   END IF
Thanks,

Joe
raback
Site Admin
Posts: 4832
Joined: 22 Aug 2009, 11:57
Antispam: Yes
Location: Espoo, Finland
Contact:

Re: SaveBoundaryValues with restarted run

Post by raback »

Hi Joe,

You're right. The test is not needed since all the variables either exist or are created. I removed the test. Fix is in the svn.

-Peter
annier
Posts: 1168
Joined: 27 Aug 2013, 13:51
Antispam: Yes

Re: SaveBoundaryValues with restarted run

Post by annier »

Hi Peter,
i just installed a fresher version of Elmer few weeks ago from svn.
If i want to use this debugging, should i reinstall it again?
Yours
Anil Kunwar
Anil Kunwar
Faculty of Mechanical Engineering, Silesian University of Technology, Gliwice
raback
Site Admin
Posts: 4832
Joined: 22 Aug 2009, 11:57
Antispam: Yes
Location: Espoo, Finland
Contact:

Re: SaveBoundaryValues with restarted run

Post by raback »

Yes. Say "svn update" in the trunk directory and recompile. -Peter
Post Reply